-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added macos dependency installation #5233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these can be moved to the github-runner provisioning pipeline, so it wont be run for every build
When dependencies are installed, each step takes around a second and the packages are not being reinstalled every time. The reason it was not put in runner provisioning script is to keep it generic and the build pipeline runner agnostic. |
we may need to specify the python version at least, once there is new python version, it might potentially cause some issue. |
Added Python version and moved both python and cmake installation under condition which will prevent unexpected updates. Tests: |
* python (3.13) and cmake (latest)
* python (3.13) and cmake (latest)
Added missing dependency installation on generic MacOS runner
High Level Overview of Change
Installing Python and cmake before the build process
Type of Change
.gitignore
, formatting, dropping support for older tooling)Test Plan
A test pipeline was run on the forked repo