Batch Amendment

[dangell7]

High Level Overview of Change

XLS spec: https://github.com/XRPLF/XRPL-Standards/blob/master/XLS-0056d-batch/README.md

Context of Change

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release

API Impact

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

Test Plan

https://gist.github.com/dangell7/3afbe8c4597a58dc2b02be598f9b7d54

[codecov]

Codecov Report

Attention: Patch coverage is 90.92628% with 48 lines in your changes missing coverage. Please review.

Project coverage is 78.2%. Comparing base (2216e5a) to head (a535bd9).

Files with missing lines	Patch %	Lines
src/xrpld/app/tx/detail/applySteps.cpp	40.0%	15 Missing ⚠️
src/xrpld/overlay/detail/PeerImp.cpp	0.0%	10 Missing ⚠️
src/xrpld/app/misc/NetworkOPs.cpp	72.7%	6 Missing ⚠️
src/xrpld/app/tx/detail/Transactor.cpp	93.4%	5 Missing ⚠️
src/xrpld/app/tx/detail/Batch.cpp	97.3%	4 Missing ⚠️
src/libxrpl/protocol/STTx.cpp	97.9%	2 Missing ⚠️
src/xrpld/app/ledger/detail/OpenLedger.cpp	33.3%	2 Missing ⚠️
src/xrpld/app/tx/detail/apply.cpp	96.7%	2 Missing ⚠️
src/xrpld/ledger/detail/OpenView.cpp	50.0%	1 Missing ⚠️
src/xrpld/rpc/detail/TransactionSign.cpp	83.3%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5060     +/-   ##
=========================================
+ Coverage     78.1%   78.2%   +0.1%     
=========================================
  Files          790     793      +3     
  Lines        67908   68329    +421     
  Branches      8230    8245     +15     
=========================================
+ Hits         53034   53418    +384     
- Misses       14874   14911     +37     

Files with missing lines	Coverage Δ
include/xrpl/protocol/Batch.h	100.0% <100.0%> (ø)
include/xrpl/protocol/Feature.h	100.0% <ø> (ø)
include/xrpl/protocol/HashPrefix.h	100.0% <ø> (ø)
include/xrpl/protocol/STTx.h	100.0% <ø> (ø)
include/xrpl/protocol/TER.h	100.0% <100.0%> (ø)
include/xrpl/protocol/TxMeta.h	93.8% <100.0%> (+2.1%)	⬆️
include/xrpl/protocol/detail/transactions.macro	100.0% <100.0%> (ø)
src/libxrpl/protocol/InnerObjectFormats.cpp	100.0% <100.0%> (ø)
src/libxrpl/protocol/TER.cpp	100.0% <ø> (ø)
src/libxrpl/protocol/TxMeta.cpp	96.5% <100.0%> (+0.3%)	⬆️
... and 23 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Speedtraders199]

Excellent, this is the festure of xrpl which is going to move from this now to another level of point of which many will never believe it but that the true for the native market price is going to move high any moment from now