Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rippled-example.cfg to clarify usage of ssl_cert and ssl_chain #4658

Closed
wants to merge 4 commits into from

Conversation

ggprod
Copy link
Contributor

@ggprod ggprod commented Aug 16, 2023

High Level Overview of Change

update notes for ssl_cert and ssl_chain to clarify that ssl_chain must be used when the certificate includes one or more intermediates

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

…t be used when the certificate includes one or more intermediates
@intelliot intelliot requested a review from ckeshava August 16, 2023 23:11
ggprod and others added 2 commits August 17, 2023 08:50
Co-authored-by: Elliot Lee <github.public@intelliot.com>
Co-authored-by: Elliot Lee <github.public@intelliot.com>
@ggprod
Copy link
Contributor Author

ggprod commented Aug 17, 2023

@intelliot should I add another comment on ssl_verify (when set to 1 it seems to prevent commands like rippled server_info from working)?

Not sure if other config impacts that or not but found that these commands gave:

{
   "error" : "internal",
   "error_code" : 73,
   "error_message" : "Internal error.",
   "error_what" : "no response from server"
}

even though doing them via curl or externally they worked fine

@ckeshava
Copy link
Collaborator

@ggprod I have observed this error when the local rippled server was stopped (Through SIGKILL or the rippled stop command)
When you use curl, you are connecting to a non-local rippled server right?

@ckeshava
Copy link
Collaborator

I'm surprised to see these two errors in the CI tests, despite not having any code changes. Do you observe this in your local unit tests too? @ggprod

1> #8 failed: ShardArchiveHandler_test.cpp(420)
1> #9 failed: ShardArchiveHandler_test.cpp(427)

@ggprod
Copy link
Contributor Author

ggprod commented Aug 18, 2023

I'm surprised to see these two errors in the CI tests, despite not having any code changes. Do you observe this in your local unit tests too? @ggprod

1> #8 failed: ShardArchiveHandler_test.cpp(420)
1> #9 failed: ShardArchiveHandler_test.cpp(427)

I didn't run unit tests as I only made changes in that one file (and only among the comments)

@ggprod
Copy link
Contributor Author

ggprod commented Aug 18, 2023

@ggprod I have observed this error when the local rippled server was stopped (Through SIGKILL or the rippled stop command) When you use curl, you are connecting to a non-local rippled server right?

in my case rippled was running fine and was responding to the same request when done using curl (either internally via localhost or externally)

@ggprod
Copy link
Contributor Author

ggprod commented Aug 19, 2023

I am closing this PR and will re-do it as I didn't sign my commit

@ggprod ggprod closed this Aug 19, 2023
@ggprod ggprod deleted the rippled-cfg-example-update branch August 19, 2023 00:07
@intelliot
Copy link
Collaborator

Replaced by #4667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants