Respond to comments

src/ripple/module/app/ledger/LedgerEntrySet.cpp

@@ -47,15 +47,6 @@ LedgerEntrySet LedgerEntrySet::duplicate () const
     return LedgerEntrySet (mLedger, mEntries, mSet, mSeq + 1);
 }
 
-void LedgerEntrySet::setTo (const LedgerEntrySet& e)
-{
-    mLedger = e.mLedger;
-    mEntries = e.mEntries;
-    mSet = e.mSet;
-    mParams = e.mParams;
-    mSeq = e.mSeq;
-}
-
 void LedgerEntrySet::swapWith (LedgerEntrySet& e)
 {
     std::swap (mLedger, e.mLedger);

src/ripple/module/app/ledger/LedgerEntrySet.h

@@ -26,17 +26,20 @@ enum TransactionEngineParams
 {
     tapNONE             = 0x00,
 
-    tapNO_CHECK_SIGN    = 0x01,     // Signature already checked
+    // Signature already checked
+    tapNO_CHECK_SIGN    = 0x01,
 
-    tapOPEN_LEDGER      = 0x10,
     // Transaction is running against an open ledger
     // true = failures are not forwarded, check transaction fee
     // false = debit ledger for consumed funds
+    tapOPEN_LEDGER      = 0x10,
 
-    tapRETRY            = 0x20,     // This is not the transaction's last pass
+    // This is not the transaction's last pass
     // Transaction can be retried, soft failures allowed
+    tapRETRY            = 0x20,
 
-    tapADMIN            = 0x400,    // Transaction came from a privileged source
+    // Transaction came from a privileged source
+    tapADMIN            = 0x400,
 };
 
 enum LedgerEntryAction
@@ -104,9 +107,6 @@ class LedgerEntrySet
     // Make a duplicate of this set.
     LedgerEntrySet duplicate () const;
 
-    // Set this set to have the same contents as another
-    void setTo (const LedgerEntrySet&);
-
     // Swap the contents of two sets
     void swapWith (LedgerEntrySet&);
 

src/ripple/module/app/misc/NetworkOPs.cpp

@@ -1210,7 +1210,7 @@ class ValidationCount
     {
     }
 
-    bool operator> (const ValidationCount& v)
+    bool operator> (const ValidationCount& v) const
     {
         if (trustedValidations > v.trustedValidations)
             return true;
@@ -1344,7 +1344,7 @@ bool NetworkOPsImp::checkLastClosedLedger (const Overlay::PeerSequence& peerList
     // 3) Is there a network ledger we'd like to switch to? If so, do we have it?
     bool switchLedgers = false;
 
-    for (auto& it: ledgers)
+    for (auto const& it: ledgers)
     {
         m_journal.debug << "L: " << it.first
                         << " t=" << it.second.trustedValidations

src/ripple/module/data/protocol/SerializedObject.h

@@ -197,6 +197,7 @@ class STObject
     std::uint32_t getFieldU32 (SField::ref field) const;
     std::uint64_t getFieldU64 (SField::ref field) const;
     uint128 getFieldH128 (SField::ref field) const;
+
     uint160 getFieldH160 (SField::ref field) const;
     uint256 getFieldH256 (SField::ref field) const;
     RippleAddress getFieldAccount (SField::ref field) const;