Update Base58 codec and remove Bitcoin support: #3581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use C++17 constant expressions to calculate the inverse alphabet map at compile time instead of at runtime. Remove support for encoding & decoding tokens using the Bitcoin alphabet.
scottschurr
suggested changes
Aug 13, 2020
HowardHinnant
approved these changes
Aug 13, 2020
|
ohoh, what happened ?
|
nbougalis
approved these changes
Aug 18, 2020
scottschurr
approved these changes
Aug 18, 2020
|
Oops. One more mechanical change needed. The clang-format continuous integration check is failing. We need to reformat a little bit of the code to make clang-format happy. You can do that yourself by running clang-format over the changed files. Or you can cherry-pick the changes that clang-format will make from this commit: scottschurr@1483ffe Sorry that I missed that earlier. |
|
Oh, and since I didn't mention it before, nice job on the commit messages. Looks great. 👍 |
carlhua
added
the
Ready to merge
Merged
mDuo13
added a commit
to mDuo13/xrpl-dev-portal
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening the closed PR #3575 sorry fo the problem @scottschurr and @HowardHinnant!