Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserve 22 as ttHOOK_SET #3557

Closed
wants to merge 1 commit into from
Closed

Conversation

RichardAH
Copy link
Collaborator

We'd like to reserve 22 as SetHook transaction type. This tt will eventually allow configurable behaviour on accounts for send and receive events.

Copy link
Contributor

@nbougalis nbougalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Just noting that the downside of reserving is that we've basically burned an ID and there's only 64k of them and I don't know that we need to reserve the transaction ID at this time, but it shouldn't really be a problem to do so.

Please consider rewording your commit:

Reserve transaction type identifier for event hooking:

Event hooks will allow accounts to introduce configurable behavior
in response to send and receive events.

P.S.: Let the English vs. U.S. spelling wars begin. "behaviour"... 🙄

@mDuo13
Copy link
Collaborator

mDuo13 commented Jul 31, 2020

I'm not concerned about burning one ID (number 153) out of 64,000. 😆

Hooks is an interesting idea. I think the scope will be paramount. Too big, and you end up with Solidity¹; too small, and you need to keep growing it with more features later. Sometimes having a bunch of specialized tools is useful, sometimes it's too complex and having one all-purpose tool is better.

¹ Solidity is cool, but bugs in smart contracts are a big problem (even the DAO couldn't get their right on the first try, and most of us don't have the option of hardforking the network if we screw up) and the more complexity, the more opportunity for bugs. Also, the more logic and state data you store on-ledger, the harder your scaling problems become.

Copy link
Contributor

@nbougalis nbougalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Should probably be squashed into one commit on merge, with a commit message:

Reserve transaction type and error codes for event hooking:

Event hooks will allow accounts to introduce configurable behavior
in response to send and receive events.

Event hooks will allow accounts to introduce configurable behavior
in response to send and receive events.
@carlhua carlhua added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Aug 24, 2020
@carlhua
Copy link
Contributor

carlhua commented Aug 24, 2020

I am giving a Passed label as this is trivial.

@nbougalis nbougalis mentioned this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants