Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake build assumes static boost libraries #2261

Closed
MarkusTeufelberger opened this issue Nov 6, 2017 · 0 comments
Closed

cmake build assumes static boost libraries #2261

MarkusTeufelberger opened this issue Nov 6, 2017 · 0 comments

Comments

@MarkusTeufelberger
Copy link
Collaborator

In https://github.com/ripple/rippled/blob/develop/Builds/CMake/CMakeFuncs.cmake#L340 set(Boost_USE_STATIC_LIBS on) is always true instead of being on a switch via if (static)

Static libraries are not always shipped, especially for boost. Please reconsider linking boost dynamically and leaving the option of linking it statically up to the user. There is already a build time option to build a static binary via cmake. https://github.com/ripple/rippled/blob/develop/Builds/CMake/CMakeFuncs.cmake#L171 seems to support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant