Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeJS test scripts seek missing config.js #2

Closed
globalcitizen opened this issue Dec 17, 2012 · 1 comment
Closed

NodeJS test scripts seek missing config.js #2

globalcitizen opened this issue Dec 17, 2012 · 1 comment

Comments

@globalcitizen
Copy link

When following the test build procedures at https://ripple.com/wiki/Build_instructions#Running_CLI_tests the amount-test.js file returns an error about a missing config.js

I was able to fix this by symlinking to testconfig.js.

I guess there are issues with multiple scripts in that dir, and/or your documentation.
@ahbritto
Copy link
Contributor

Documented how to create a config.js: https://ripple.com/wiki/Build_instructions#Configuration

@gmosx gmosx mentioned this issue Mar 16, 2013
Closed
@BobWay BobWay mentioned this issue Jun 26, 2013
Closed
This was referenced Jul 1, 2013
Closed
Closed
@alexdupre alexdupre mentioned this issue Jul 11, 2013
Closed
wufeipeng pushed a commit to peersafe/rippled that referenced this issue Nov 20, 2017
@peersafe
Merge pull request XRPLF#2 from peersafe/feature/headerInclude
bd7cfdd 
amend including
@passionofvc passionofvc mentioned this issue Jan 25, 2018
Closed
@professorhantzen professorhantzen mentioned this issue Mar 11, 2018
Closed
@dmitryrn dmitryrn mentioned this issue Jun 12, 2019
Closed
ximinez referenced this issue in ximinez/rippled Aug 9, 2019
@ximinez
[FOLD] Review feedback #2: Second batch from @seelabs:
7dbbc06 
* Simplify the calculations in LoadFeeTrack.
* Make commutative operator* a friend instead of a free function in
  XRPAmount and TaggedFee.
ximinez referenced this issue in ximinez/rippled Aug 19, 2019
@ximinez
[FOLD] Review feedback #2: Second batch from @seelabs:
cce64fa 
* Simplify the calculations in LoadFeeTrack.
* Make commutative operator* a friend instead of a free function in
  XRPAmount and TaggedFee.
ximinez referenced this issue in ximinez/rippled Aug 26, 2019
@ximinez
[FOLD] Review feedback #2: Second batch from @seelabs:
3355ce5 
* Simplify the calculations in LoadFeeTrack.
* Make commutative operator* a friend instead of a free function in
  XRPAmount and TaggedFee.
ximinez referenced this issue in ximinez/rippled Sep 9, 2019
@ximinez
[FOLD] Review feedback #2: Second batch from @seelabs:
c461a9f 
* Simplify the calculations in LoadFeeTrack.
* Make commutative operator* a friend instead of a free function in
  XRPAmount and TaggedFee.
ximinez referenced this issue in ximinez/rippled Oct 2, 2019
@ximinez
[FOLD] Review feedback #2: Second batch from @seelabs:
c069fa1 
* Simplify the calculations in LoadFeeTrack.
* Make commutative operator* a friend instead of a free function in
  XRPAmount and TaggedFee.
seelabs referenced this issue in seelabs/rippled Jan 1, 2020
@nbougalis @seelabs
Improve the 'network_id' configuration option:
22e3f3c 
The 'network_id' option allows an administrator to specify to which
network they intend a server to connect. Servers can leverage this
information to optimize routing and prune automatically discovered
cross-network connections.

This commit will, if merged:

- add support for the devnet keyword, which corresponds to network ID #2;
- report the network ID, if one is configured, in server_info
seelabs referenced this issue in seelabs/rippled Jan 1, 2020
@nbougalis @seelabs
Improve the 'network_id' configuration option:
c04d509 
The 'network_id' option allows an administrator to specify to which
network they intend a server to connect. Servers can leverage this
information to optimize routing and prune automatically discovered
cross-network connections.

This commit will, if merged:

- add support for the devnet keyword, which corresponds to network ID #2;
- report the network ID, if one is configured, in server_info
@ximinez ximinez mentioned this issue Jan 26, 2021
Open
@luleigreat luleigreat mentioned this issue Dec 14, 2021
Open
natenichols added a commit to natenichols/rippled that referenced this issue Dec 15, 2021
@natenichols
# This is a combination of 3 commits.
72d75c3 
# This is the 1st commit message:

[FOLD] rebase

# This is the commit message XRPLF#2:

[FOLD] Formatting

# This is the commit message XRPLF#3:

[FOLD] format test
@mtrippled mtrippled mentioned this issue Mar 13, 2023
Merged
6 tasks
This was referenced Mar 23, 2023
Open
Open
@intelliot intelliot mentioned this issue Jul 4, 2023
Merged
7 tasks
Bronek referenced this issue in Bronek/rippled Nov 29, 2023
@Bronek
Diagnosing MSVC ICE build error #2
ef3f1a8
Bronek referenced this issue in Bronek/rippled Nov 29, 2023
@Bronek
Diagnosing MSVC ICE build error #2
45aad36
Bronek referenced this issue in Bronek/rippled Nov 29, 2023
@Bronek
Revert "Diagnosing MSVC ICE build error #2"
e13de79 
This reverts commit 45aad36.
@bachase bachase mentioned this issue Nov 7, 2024
Merged
13 tasks
vlntb added a commit to vlntb/rippled that referenced this issue Dec 16, 2024
@vlntb
Addressing review comments XRPLF#2
f9650ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@globalcitizen @ahbritto