Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/develop' into relay
Browse files Browse the repository at this point in the history
* upstream/develop:
  Remove flow assert: (5009)
  Update list of maintainers: (4984)
  • Loading branch information
ximinez committed May 1, 2024
2 parents f67f346 + 5aa1106 commit 3863b01
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
1 change: 0 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,6 @@ existing maintainer without a vote.
* [JoelKatz](https://github.com/JoelKatz) (Ripple)
* [manojsdoshi](https://github.com/manojsdoshi) (Ripple)
* [n3tc4t](https://github.com/n3tc4t) (XRPL Labs)
* [Nik Bougalis](https://github.com/nbougalis)
* [nixer89](https://github.com/nixer89) (XRP Ledger Foundation)
* [RichardAH](https://github.com/RichardAH) (XRPL Labs + XRP Ledger Foundation)
* [seelabs](https://github.com/seelabs) (Ripple)
Expand Down
8 changes: 7 additions & 1 deletion src/ripple/app/paths/impl/StrandFlow.h
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,13 @@ flow(
{
if (actualOut > outReq)
{
assert(0);
// Rounding in the payment engine is causing this assert to
// sometimes fire with "dust" amounts. This is causing issues when
// running debug builds of rippled. While this issue still needs to
// be resolved, the assert is causing more harm than good at this
// point.
// assert(0);

return {tefEXCEPTION, std::move(ofrsToRmOnFail)};
}
if (!partialPayment)
Expand Down

0 comments on commit 3863b01

Please sign in to comment.