Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding promoteId as input for mgl-vector-source and mgl-geojson-source #245

Closed
magnolo opened this issue Sep 8, 2020 · 2 comments
Closed

Adding promoteId as input for mgl-vector-source and mgl-geojson-source #245

magnolo opened this issue Sep 8, 2020 · 2 comments

Comments

@magnolo
Copy link

magnolo commented Sep 8, 2020

Hello there, i am so blessed and thankful for your work and effort for this lib. I am using it very intense and its great.
I am following a lot of your issues and sometimes i whish i had time to contribute to it and help out a bit. Maybe soon...

My issue here is, that i would like to use a promoteId input for mainly mgl-vector-source so i could use setFeatureState for some of my user interactions and data changes. Would it be possible to integrate it in near future?

I think this wouldnt be a big update and no breaking change. (but just thinking, not knowing)

love M
magnolo added a commit to magnolo/ngx-mapbox-gl that referenced this issue Sep 8, 2020
@magnolo
feat(sources): support promoteId as input for mgl-vector-source and m…
45511e3 
…gl-geojson-source (Wykks#245)
@ezk84
Copy link

ezk84 commented Jan 8, 2021

This was fixed with #253, AFAIK?

@dmytro-gokun
Copy link
Collaborator

@ezk84 Yes, it was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmytro-gokun @ezk84 @magnolo