This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Async subclasses can now decorate their target functions #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a couple reasons you'd want to leverage this: 1. Instead of decorating every target function's definition, just use the appropriate Async type. 2. When you only want the decorated function for tasks. Examples of the latter, where you'd want extra functionality for the Task but not when using the target function as a normal local procedure call, would be: - logging out extra context for the task - top-level try/except handling for the task - a retry loop, instead of just kicking off a new task when a transient error happens
|
+1 very nice |
|
lgtm Any additional testing been done on this? |
|
@beaulyddon-wf I installed this branch on a local dev server as well as appspot. The |
|
+1 |
beaulyddon-wf
added a commit
that referenced
this pull request
Nov 13, 2015
Async subclasses can now decorate their target functions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a couple reasons you'd want to leverage this:
appropriate Async type.
Examples of the latter, where you'd want extra functionality for the Task but
not when using the target function as a normal local procedure call, would be:
happens
@markshaule-wf @andreleblanc-wf @beaulyddon-wf @tylertreat
FYI @macleodbroad-wf