This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses concerns over completion checks and cleanup tasks occurring in the default queue in BigSky.
Three configurable options were added
cleanupqueue - where cleanup tasks for completion markers should be run
cleanupdelay - how long should cleanup tasks be delayed
defaultqueue - what is the default queue for completion and cleanup tasks (if no cleanupqueue is defined)
Completion checks will now inherit which queue they will run in from the tasks that kick them off. There is a new example of how this works added to the examples folder called context_inherit.
This pattern of inheritance allows greater freedom to shard async's across different queues and balance out their own performance (completion performance included).
@beaulyddon-wf @tylertreat @tannermiller-wf @johnlockwood-wf