Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles: Update print styles #432

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Styles: Update print styles #432

merged 1 commit into from
Oct 31, 2024

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Oct 24, 2024

Fixes #427 — This brings over some of the print styles added to the parent theme in WordPress/wporg-parent-2021#158 to address the follow-up comments on #427.

This PR relies on #431 for the local navigation bar. Once merged, that can be used for context in print like it is on the rest of the website. The other changes here are fixes for the homepage, mostly reducing the font size and space between elements, and fixing the people of WP images.

Example PDFs printed from Chrome:

@ryelle ryelle added the [Component] Theme Front-end help needed label Oct 24, 2024
@ryelle ryelle self-assigned this Oct 24, 2024
Copy link
Collaborator

@StevenDufresne StevenDufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Not blocking, but I noticed there is a little duplication with page titles being displayed in both the nav bar and post content:

Screenshot 2024-10-31 at 12 05 19 PM

Screenshot 2024-10-31 at 12 05 58 PM

And maybe post navigation could be hidden on archives

Screenshot 2024-10-31 at 12 05 33 PM

Base automatically changed from update/sticky-header to trunk October 31, 2024 14:55
@ryelle ryelle force-pushed the update/print-styles branch from 98c37ac to e9bc102 Compare October 31, 2024 15:07
@ryelle
Copy link
Contributor Author

ryelle commented Oct 31, 2024

Not blocking, but I noticed there is a little duplication with page titles being displayed in both the nav bar and post content:

True, but there are places where it wouldn't be duplication (the category archives), so I think I'll leave it.

And maybe post navigation could be hidden on archives

Done!

@ryelle ryelle merged commit 25a29d4 into trunk Oct 31, 2024
@ryelle ryelle deleted the update/print-styles branch October 31, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Front-end help needed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve the print stylesheet for News
3 participants