Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji replacement is running on the arrow in menu's #578

Closed
dd32 opened this issue Feb 15, 2024 · 2 comments
Closed

Emoji replacement is running on the arrow in menu's #578

dd32 opened this issue Feb 15, 2024 · 2 comments
Labels

Comments

@dd32
Copy link
Member

dd32 commented Feb 15, 2024

Screenshot 2024-02-15 at 3 59 10 pm Screenshot 2024-02-15 at 3 59 19 pm

This is WordPress/wporg-parent-2021#58 no longer applying, unsure why, but could be related to the aria-hidden callback.

The upstream fix has been applied, so we should be able to simply add wp-exclude-emoji to the entire nav menu now.

@ryelle ryelle moved this to 📋 To do in WordPress.org Feb 15, 2024
@ryelle ryelle added the [Type] Bug Something isn't working label Feb 15, 2024
@ryelle
Copy link
Contributor

ryelle commented Feb 15, 2024

I'm not seeing this right now, was it happening before Gutenberg was pinned, maybe?

@dd32
Copy link
Member Author

dd32 commented Feb 16, 2024

This only happens on old browsers that need the Emoji replacement in the first place.

In this case, it's Chrome Version 121.0.6167.160 (Official Build) (64-bit) on Linux w/ XFce.

ryelle added a commit to WordPress/wporg-parent-2021 that referenced this issue Mar 8, 2024
The variation selector code is causing Safari to render these arrows as [?]. Rather than chase that down, we can remove the variation selector code, in favor of adding the `wp-exclude-emoji` class to the arrow wrapper span. This fixes the arrows in Safari, while still preventing the emoji replacement.

See WordPress/wporg-mu-plugins#578
@ryelle ryelle closed this as completed in 4e37233 Mar 8, 2024
@ryelle ryelle moved this from 📋 To do to ✅ Done in WordPress.org Mar 21, 2024
DanyloKubyshkin added a commit to DanyloKubyshkin/wordpress-org that referenced this issue Jul 12, 2024
The variation selector code is causing Safari to render these arrows as [?]. Rather than chase that down, we can remove the variation selector code, in favor of adding the `wp-exclude-emoji` class to the arrow wrapper span. This fixes the arrows in Safari, while still preventing the emoji replacement.

See WordPress/wporg-mu-plugins#578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants