-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji replacement is running on the arrow in menu's #578
Labels
Comments
I'm not seeing this right now, was it happening before Gutenberg was pinned, maybe? |
This only happens on old browsers that need the Emoji replacement in the first place. In this case, it's |
ryelle
added a commit
to WordPress/wporg-parent-2021
that referenced
this issue
Mar 8, 2024
The variation selector code is causing Safari to render these arrows as [?]. Rather than chase that down, we can remove the variation selector code, in favor of adding the `wp-exclude-emoji` class to the arrow wrapper span. This fixes the arrows in Safari, while still preventing the emoji replacement. See WordPress/wporg-mu-plugins#578
DanyloKubyshkin
added a commit
to DanyloKubyshkin/wordpress-org
that referenced
this issue
Jul 12, 2024
The variation selector code is causing Safari to render these arrows as [?]. Rather than chase that down, we can remove the variation selector code, in favor of adding the `wp-exclude-emoji` class to the arrow wrapper span. This fixes the arrows in Safari, while still preventing the emoji replacement. See WordPress/wporg-mu-plugins#578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is WordPress/wporg-parent-2021#58 no longer applying, unsure why, but could be related to the aria-hidden callback.
The upstream fix has been applied, so we should be able to simply add
wp-exclude-emoji
to the entire nav menu now.The text was updated successfully, but these errors were encountered: