Twenty Twenty-Three: Try replacing base and contrast with ref values #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
commented
Nov 21, 2022
| { | ||
| "color": "#ff5252", | ||
| "name": "Block out Red", | ||
| "slug": "block-out-red" |
There was a problem hiding this comment.
I struggled to name some of these colors! I don't think the name in particular matters too much, but it would be good if the name described the color, or perhaps matched the personality of the style variation.
mikachan
commented
Nov 21, 2022
| @@ -138,7 +133,9 @@ | |||
| "elements": { | |||
| "link": { | |||
| "color": { | |||
| "text": "var(--wp--preset--color--contrast)" | |||
| "text": { | |||
| "ref": "styles.color.text" | |||
There was a problem hiding this comment.
ref currently isn't included in the theme.json schema, so it will throw a warning in text editors.
There is a PR here to address this: WordPress/gutenberg#45897
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
baseandcontrastcolor palette names in Twenty Twenty-Three with descriptive names (e.g. "dark purple"), and usesrefvalues for where we were previously usingvar(--wp--preset--color--contrast)orvar(--wp--preset--color--base).I haven't included colors in the color palettes that are already included as part of Core, such as
#000000and#FFFFFF.Trac ticket: https://core.trac.wordpress.org/ticket/57167
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.