Improve DotTip positioning fix #7219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an official refresh() method to Popover so that DotTip can call this instead of relying on internal Popover methods.
aduth
reviewed
Jul 30, 2018
|
|
||
| ### refresh | ||
|
|
||
| Calling `refresh()` will force the Popover to recalculate its size and position. This is useful when a DOM change causes the anchor node to change position. |
There was a problem hiding this comment.
As a developer scanning only the code of the component, this comment would have been useful as a JSDoc of the refresh function itself. I didn't notice this documentation existed until I arrived here by git blame to complain 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7071. Add an official
refresh()method to Popover so that DotTip can call this instead of relying on internal Popover methods.To test:
GUTENBERG_NUX_1from local storage