Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to toggle keyboard shortcuts on/off #69353

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Sukhendu2002
Copy link
Contributor

What?

Closes: #69146

This PR adds a toggle option in the keyboard shortcuts help modal that allows users to enable or disable all keyboard shortcuts globally throughout the editor.

Testing Instructions

  1. Open the WordPress editor and create or edit a post
  2. Open the keyboard shortcuts modal
  3. Observe the new toggle control at the top of the modal labeled "Enable keyboard shortcuts"
  4. Toggle it off and close the modal

Screenshots or screencast

image

@Mamaduka
Copy link
Member

Thanks for contributing, @Sukhendu2002.

I think this needs to be discussed first before we move forward with implementation.

@t-hamano
Copy link
Contributor

Perhaps users would prefer to toggle shortcuts individually, rather than all at once. Additionally, a more ideal approach would be to make shortcuts customizable. See #3218

@Mamaduka
Copy link
Member

Right, configurable shortcuts seem more flexible solutions.

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Package] Keyboard Shortcuts /packages/keyboard-shortcuts labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Keyboard Shortcuts /packages/keyboard-shortcuts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Offer option to toggle off keyboard shortcuts
3 participants