fix ensure post meta panel stays visible in all rendering modes #69083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiankaegy
added
[Type] Regression
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -12 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
stokesman
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
LGTM.
I tested with the playground PR previewer on 6.7.1.
- The meta boxes are present regardless of whether viewing the template or post only.
- Device previews switch meta boxes from the split view to the after editor content location per [WP6.7] Keep meta boxes unsplit from content in device previews #68902 (either viewing template or post-only)
carolinan
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
I installed 6.7.2-RC1-59764 (the nightly) with the beta tester plugin
Then I applied this PR and activated Gutenberg and Yoast SEO 24.4.
I tested with and without custom fields enabled, in addition to the plugin.
The meta boxes show when "show template" is enabled.
aaronjorbin
approved these changes
Feb 7, 2025
aaronjorbin
deleted the
fix/ensure-metafields-stay-visible-in-all-rendering-modes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
this ensures the changes in #66508 what were undone in #68902 are actually applied
Why?
to ensure the fix in #66508 actually works in 6.7.2
How?
removing the rendering mode check
Testing Instructions
he change.
CleanShot.2025-02-06.at.22.34.31.mp4