Close the post publish panel only when the post becomes dirty #6822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
youknowriad
commented
May 18, 2018
test/e2e/support/utils.js
Outdated
| @@ -3,6 +3,7 @@ | |||
| */ | |||
| import { join } from 'path'; | |||
| import { URL } from 'url'; | |||
| import { SSL_OP_CRYPTOPRO_TLSEXT_BUG } from 'constants'; | |||
youknowriad
force-pushed
the
fix/post-publish-close-panel
branch
2 times, most recently
from
d0da8f1 to
eba0562
Compare
gziolo
approved these changes
May 18, 2018
youknowriad
force-pushed
the
fix/post-publish-close-panel
branch
from
eba0562 to
10e9fa7
Compare
4 tasks
aduth
reviewed
May 24, 2018
| await page.click( '.editor-post-publish-panel__toggle' ); | ||
|
|
||
| // Wait for a second ( wait for the animation ) | ||
| await wait( 1000 ); |
There was a problem hiding this comment.
Is there a way to express this with waitForSelector (e.g. a class or pseudo-class on the available button)? How else can we discourage using wait as a crutch? Could we call this something like waitDurationYesImCertainWaitForSelectorIsNotABetterOption( 1000 ) ?
There was a problem hiding this comment.
:) haha I like the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced here #6209 (comment) where we consider post being saved as dirty, so we need to ensure we're not saving the post before closing the post publish panel.
Testing instructions