Introduce wp:action-publish; update corresponding UI to reference
#6670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'type' => 'object', | ||
| 'properties' => array( | ||
| 'status' => array( | ||
| 'type' => 'string', |
There was a problem hiding this comment.
If this is only for publish, then it should have an enum entry. "enum": [ "publish", "future" ]
There was a problem hiding this comment.
cf894ca175f7c8826f7e55c07dc56d3a1dbbbaa7
|
Bit by #6683 |
danielbachhuber
force-pushed
the
6361-action-publish
branch
from
b0473f4 to
b750e88
Compare
youknowriad
reviewed
May 10, 2018
| return { | ||
| hasPublishAction: get( getCurrentPost(), [ '_links', 'wp:action-publish' ], false ), |
There was a problem hiding this comment.
I feel there should be a dedicated selector or a mechanism to make this clearer. I see selectors as something that should reflect data needs. I don't have the perfect solution though:
- Something like
canDoActionOnCurrentPost( state, 'publish' )would work but it's specific to the current post. - Just an utility like
canDoAction( record, 'publish' )could work too but it enforces the fact that the_linksproperty is part of the record where ideally it shouldn't be.
There was a problem hiding this comment.
I think this is covered by, #6655.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a
wp:action-publishtargetSchemaattribute and updatespost-pending-status,post-schedule, andpost-visibilityto reference it.See #6361
Previously #6529 #6630
How has this been tested?
Sign in as an Author to see the corresponding UI as editable:
As a Contributor, this UI is no longer accessible:
Checklist: