Use a "users" reducer combined with a "queries" sub state to map authors to users #6522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
commented
May 1, 2018
| const authors = await apiRequest( { path: '/wp/v2/users/?who=authors' } ); | ||
| yield receiveAuthors( authors ); | ||
| const users = await apiRequest( { path: '/wp/v2/users/?who=authors' } ); | ||
| yield receiveUserQuery( 'authors', users ); |
There was a problem hiding this comment.
I'm hard-coding the queryID ('authors') for now but it could be generated from the query args if we want to generalize this later.
4 tasks
youknowriad
commented
May 1, 2018
| * | ||
| * @return {Array} Users list. | ||
| */ | ||
| export function getUserQueryResults( state, queryID ) { |
There was a problem hiding this comment.
This selector should probably be memoized to avoid generating an new array on each call.
danielbachhuber
approved these changes
May 1, 2018
danielbachhuber
added a commit
that referenced
this pull request
May 2, 2018
) * Switch `post-author` component to use `/wp/v2/users/?who=authors` * Ensure state is always an array, properly * Update tests for 80d0500 * Remove unused variable * Remove unnecessary prop pass-through * Ensure no duplicate authors are listed * Use a "users" reducer combined with a "queries" sub state to map authors to users (#6522)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges into #6515