Update radius #63447
Closed
Update radius #63447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Size Change: +200 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Jul 17, 2024
Comment on lines
114
to
+115
| $block-padding: 14px; // Used to define space between block footprint and surrouding borders. | ||
|
|
||
| $radius-block-ui: $radius; |
There was a problem hiding this comment.
We should probably add linter rules to prevent folks from using those. and eventually remove them from the package.
It will also help us to make sure we're not missing any occurrences in this refactor.
| $radius-10: $radius * 1; | ||
| $radius-20: $radius * 2; | ||
| $radius-30: $radius * 3; | ||
| $radius-full: $radius * 999; |
There was a problem hiding this comment.
Checking here that this is on purpose vs using values like 50% or 100%
There was a problem hiding this comment.
I may be mis-understanding the question but; yes, because percentage values produce a different result to absolute ones when applied to non-square elements.
| Absolute | Percentage |
|---|---|
 |
 |
In UI design I think it's quite rare to need % based radii.
There was a problem hiding this comment.
Sounds good, I just wanted to make sure the intended meaning of "full" radius 👌
| radiusPrimitive: '4px', | ||
| radiusSmallContainer: '8px', | ||
| radiusLargeContainer: '12px', | ||
| radiusFull: '999px', |
There was a problem hiding this comment.
Super nitty 😅 but technically radiusFull should be 4 * 999 = 3996px in order to mimic the sass counterpart
| @@ -43,6 +43,11 @@ export default Object.assign( {}, CONTROL_PROPS, TOGGLE_GROUP_CONTROL_PROPS, { | |||
| colorScrollbarTrack: 'rgba(0, 0, 0, 0.04)', | |||
| elevationIntensity: 1, | |||
| radiusBlockUi: '2px', | |||
There was a problem hiding this comment.
Should we remove radiusBlockUi, since it's not exported from the package?
|
@ciampo do you have suggestions about how to ship a change like this? Should it be broken down into smaller pieces? I'm conscious of how many files are touched here. |
|
The more cautious way to introduce these changes would be to split the work across a few PRs:
What do you think? |
|
Sounds like a plan. |
|
Closing this in favor of a more iterative rollout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the radius scale outlined in #63703. It is a proof of concept meant only to test different values in the proposed scale, applied across the app.