Editor: Use visibility selector for PostTemplatePanel #57224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Bug
ciampo
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Looks reasonable, looking at the changes in #56817
Thank you!
|
Thank you for the review, @ciampo! I'm not authorized to merge PRs, so I suppose someone should do that for me, correct? |
tyxla
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
#56817 (likely unintentionally) introduced a hardcoded visibility flag for the PostTemplatePanel, causing it to be always visible on non-block themes for all post types.
How?
Assign the
useSelect()call to theisVisiblevariable.Testing Instructions
twentyfourteen), open the block editor for a post type that's not expected to allow setting a page template, e.g.post.page, and not visible forpost.