DataViews: Fix pagination on manual input #55940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
force-pushed
the
fix/dataviews-pagination-check
branch
from
2cf598c to
b586c79
Compare
|
Size Change: +5 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Nov 7, 2023
| @@ -83,16 +83,17 @@ function Pagination( { | |||
| min={ 1 } | |||
| max={ totalPages } | |||
| onChange={ ( value ) => { | |||
| const _value = +value; | |||
There was a problem hiding this comment.
This is the fix? Can you explain it. It's a bit obscure?
There was a problem hiding this comment.
The value of the input on the onChange callback is a string and we keep an integer in our view config. That made some strict checks to fail.
There was a problem hiding this comment.
Ah ok, maybe we should do parseInt instead of the + trick. (as you wish)
youknowriad
approved these changes
Nov 7, 2023
oandregal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #55937
When manually entering a page number in the pagination control, an invalid page number incorrectly enables the previous pagination controls, allowing the user to "access" pages below 1.
Testing Instructions