Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Update test assertion to match test name #54260

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Button: Update test assertion to match test name #54260

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a0ff8a
Button: Update test assertion to match test name
brookewp Sep 7, 2023
b039095
Restore replaced assertion for button
brookewp Sep 8, 2023
b4d2cea
Merge branch 'trunk' into update/button-test
brookewp Sep 12, 2023
ea90b50
Update assertions after changes to tooltip in #54312
brookewp Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/components/src/button/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,8 @@ describe( 'Button', () => {
} );

it( 'should populate tooltip with description content for buttons with visible labels (buttons with children)', async () => {
const user = userEvent.setup();

render(
<Button
label="Label"
Expand All @@ -258,6 +260,16 @@ describe( 'Button', () => {
description: 'Description text',
} )
).toBeVisible();

await user.tab();

expect(
screen.getByRole( 'tooltip', {
name: 'Description text',
} )
).toBeVisible();

await cleanupTooltip( user );
} );

it( 'should allow tooltip disable', async () => {
Expand Down