Storybook: Update TypeScript types #53748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
|
👍 I'll take this into account on next contributions |
brookewp
reviewed
Aug 21, 2023
| return <Button { ...props }></Button>; | ||
| }; | ||
|
|
||
| export const Default: Story< typeof Button > = Template.bind( {} ); | ||
| export const Default = Template.bind( {} ); |
There was a problem hiding this comment.
I'm curious why some stories have the type removed (Story< typeof Button > in this case) whereas in others, it is changed from Story to StoryFn, like in ColorIndicator:
There was a problem hiding this comment.
Good question. These explicit typings weren't necessary to begin with, because Template is already typed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #53520
What?
Updates the deprecated
ComponentMetaandComponentStorytypes toMetaandStoryFn.Why?
This resolves all the TypeScript warnings for the deprecated types.
Moving forward, new stories should be written in the CSF3 format using the
StoryObjtype, but for now the existing CSF2 stories will be kept as is.Testing Instructions
✅ CI checks pass
cc @bangank36