Try using maxHeight instead of height in the dimensions tool #53365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Type] Bug
|
Size Change: +137 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue that @scruffian found when testing #53274.
Here we try to set
maxHeightinstead ofheightwhen changing the dimensions tool. In #53274, theheightattribute was hard-coded to'auto'when using the drag controls.I'm a bit unsure of this solution for image blocks in horizontal contexts such as the row block.
This doesn't really fix issues some images may be smaller than the height listed and won't be scaled up to match the size they were set to.
But, we're giving it a try to see how the idea pans out and if those issues can be resolved.
I think the heuristic for most users is that the aspect ratio is unchanging when both width and height are set or when the aspect ratio is set regardless of
max-widthbeing set in the block CSS.Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast