Remove legacy isTopLevelLink attribute from Navigation block tests #51759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 16bd348. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5335970034
|
MaggieCabrera
requested review from
draganescu,
scruffian,
getdave,
jeryj and
ajlende
MaggieCabrera
changed the title
getdave
changed the title
getdave
added
[Type] Code Quality
getdave
approved these changes
Jun 22, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes all instances of
isTopLevelLinkfrom the nav block testsWhy?
Because it's a deprecated attribute
How?
Just removed the attribute where we had it
Testing Instructions
Check that the tests still pass