Code

Improve LinkControl Edit UI#51712

Code

Merged

priethor merged 33 commits intotrunkWordPress/gutenberg:trunkfrom tweak/link-control-edit-uiWordPress/gutenberg:tweak/link-control-edit-uiCopy head branch name to clipboardJun 26, 2023

+270-249

Commits

Commits on Jun 26, 2023

• Move text above link

  

  richtabor

  authored and

  getdave

  committed
  bd8b3fc

  Copy full SHA for bd8b3fc

• Change "URL" label to "Link"

  

  richtabor

  authored and

  getdave

  committed
  e79a678

  Copy full SHA for e79a678

• Style tweaks

  

  richtabor

  authored and

  getdave

  committed
  f76f8a9

  Copy full SHA for f76f8a9

• Add chevron based advanced settings button

  

  richtabor

  authored and

  getdave

  committed
  c0552f5

  Copy full SHA for c0552f5

• Adapt logic for rendering actions and settings

  

  richtabor

  authored and

  getdave

  committed
  87b47c5

  Copy full SHA for 87b47c5

• Tweaks

  

  richtabor

  authored and

  getdave

  committed
  671914b

  Copy full SHA for 671914b

• Add proper i18n

  Show description for 11c0998
  

  2 peopleauthored and

  getdave

  committed
  11c0998

  Copy full SHA for 11c0998

• Remove commented out style

  Show description for ada13cb
  

  2 peopleauthored and

  getdave

  committed
  ada13cb

  Copy full SHA for ada13cb

• Use $button-size-next-default-40px

  

  richtabor

  authored and

  getdave

  committed
  37dee3e

  Copy full SHA for 37dee3e

• Add showSettings, combine with new logic

  

  richtabor

  authored and

  getdave

  committed
  6c550c4

  Copy full SHA for 6c550c4

• Add additional translation context to advanced

  

  richtabor

  authored and

  getdave

  committed
  b277518

  Copy full SHA for b277518

• Update toggle drawer name in tests

  getdave

  committed
  eec4bef

  Copy full SHA for eec4bef

• Standardise query for settings toggle

  getdave

  committed
  62ef07b

  Copy full SHA for 62ef07b

• Update test to check for absence of cancel button during link creation

  getdave

  committed
  5ab42eb

  Copy full SHA for 5ab42eb

• Fix cancellation tests

  getdave

  committed
  8c03ac1

  Copy full SHA for 8c03ac1

• Ensure label is always “Link” but remains hidden when it’s the only visible control

  getdave

  committed
  1ebaba2

  Copy full SHA for 1ebaba2

• Update tests to look for “Link” instead of “URL” name for input

  getdave

  committed
  f6619c3

  Copy full SHA for f6619c3

• Update empty value UI tests to only run for editing as opposed to creating links

  getdave

  committed
  c12e3ce

  Copy full SHA for c12e3ce

• Fix e2e test tabbing order

  getdave

  committed
  3cf9343

  Copy full SHA for 3cf9343

• Use updated terms

  getdave

  committed
  f6a7c1e

  Copy full SHA for f6a7c1e

• Select settings toggle by text not aria label

  getdave

  committed
  e1d1305

  Copy full SHA for e1d1305

• Fix another tabbing order bug

  getdave

  committed
  fac61cc

  Copy full SHA for fac61cc

• Fix one more tabbing issue in e2e tests

  getdave

  committed
  c1297e3

  Copy full SHA for c1297e3

• Fix final tab ordering e2e test

  getdave

  committed
  8c9f1a8

  Copy full SHA for 8c9f1a8

• Decouple conditions for showing action buttons from settings

  Show description for 1bc002e
  getdave

  committed
  1bc002e

  Copy full SHA for 1bc002e

• Tweak styling to account for action buttons when there are no settings provided

  getdave

  committed
  a25340b

  Copy full SHA for a25340b

• Fix test

  getdave

  committed
  531ad75

  Copy full SHA for 531ad75

• Fix e2e test

  

  scruffian

  authored and

  getdave

  committed
  b3cb16f

  Copy full SHA for b3cb16f

• Update name of the combobox

  

  scruffian

  authored and

  getdave

  committed
  86898b2

  Copy full SHA for 86898b2

• Fix test expecting Submit button on creation

  getdave

  committed
  e1d499b

  Copy full SHA for e1d499b

• Fix test by testing under edit rather than creation conditions

  getdave

  committed
  ffb0435

  Copy full SHA for ffb0435

• Rename URL to Link and avoid triggering command centre

  getdave

  committed
  a78ba7e

  Copy full SHA for a78ba7e

• move test earlier

  scruffian

  committed
  389cb5a

  Copy full SHA for 389cb5a