Update the 'Iframe block' test and fix flakiness #51631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
Mamaduka
commented
Jun 19, 2023
| @@ -13,36 +13,17 @@ test.describe( 'Iframed block', () => { | |||
| await requestUtils.deactivatePlugin( 'gutenberg-test-iframed-block' ); | |||
| } ); | |||
|
|
|||
| test( 'Should save the changes', async ( { editor, page } ) => { | |||
| test( 'should load script and dependencies in iframe', async ( { | |||
There was a problem hiding this comment.
The previous test name wasn't descriptive of the actual test and probably a copy/paste error during the migration (#44164).
I've restored the original name.
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
|
Flaky tests detected in b11c611. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5308407466
|
kevin940726
approved these changes
Jun 19, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #43174.
PR updates the
Iframe blocke2e tests and removes extra steps for switching to template editing mode.Why?
The post editor now uses iframe by default, so there's no need to switch to template editing mode for testing with iframes.
Testing Instructions