Site editor: Simplify the template revert snackbar #50626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…removes the need to remove the notice
glendaviesnz
added
[Type] Enhancement
|
@Mamaduka after fixing the delete templates notice I realised we could simplify the revert template one if we include the template name as delete does. This way we don't need to clear the notice each as time the snackbar updates with the new template name. |
|
Size Change: -13 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2725ca2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4976631036
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the template name to the template revert snackbar
Why?
This makes it act the same as the template delete snackbar, and removes the need to remove the snackbar between reverts as the snackbar updates with new template name.
How?
Adds the rendered name from template object to the snackbar notice
Testing Instructions
Clear customizationsoption in overflow menu to remove all customizationsScreenshots or screencast
no-remove.mp4