[Mobile] - Update Header component to use the useEditorWrapperStyles hook
#50400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 5, 2023 19:04
…ble to export native-only references
…e ReadableContentView usage
geriux
added
[Status] In Progress
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
geriux
added
Mobile App - Automation
dcalhoun
approved these changes
May 8, 2023
geriux
removed
the
Mobile App - Automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes wordpress-mobile/gutenberg-mobile#5685
What?
This PR updates the
Headercomponent to use theuseEditorWrapperStyleshook instead of theReadableContentViewcomponent.Why?
To use the recently added
useEditorWrapperStyleshook so we can deprecate the usage ofReadableContentView.How?
First, it creates the native
indexentry point for theblock-editorpackage, which will export all from the web's entry point plus native-only exports like theuseEditorWrapperStyleshook.It updates the
Headercomponent by removing the usage of theReadableContentViewcomponent in favor of theuseEditorWrapperStyleshook. For this case, no options are needed to be set for the hook since the header's width is limited to the maximum width of the canvas. Although if in the future we want to allow a full-size option we can just pass thealignoption and it will automatically adapt.Testing Instructions
Test the title shows with the expected size and margins, check the same in landscape.
Testing Instructions for Keyboard
N/A
Screenshots or screencast