Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing Flow: Clicking the default appender, triggers the isTyping mode #5026

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Writing Flow: Clicking the default appender, triggers the isTyping mode #5026

merged 1 commit into from
Feb 15, 2018

Conversation

youknowriad
Copy link
Contributor

related #4492

Testing instructions

  • Click "write story" on an empty post
  • The block toolbar shouldn't show up, you're automatically in the isTyping mode

@youknowriad youknowriad self-assigned this Feb 13, 2018
@youknowriad youknowriad requested a review from mtias February 13, 2018 09:59
@youknowriad youknowriad force-pushed the update/tweak-is-typing branch from c683e57 to bbe948d Compare February 13, 2018 13:22
@aduth
Copy link
Member

aduth commented Feb 13, 2018

Noting that there was some hesitation of this idea (which I share) expressed at #4492 (comment)

aduth
aduth approved these changes Feb 13, 2018
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise this looks good to me.

Adding Design Review label, but in my personal opinion using it, it feels quite nice, and the toolbar appears exactly when I'd expect it to, e.g. selecting text, or just wildly moving my cursor hoping to find such controls.

@aduth aduth added Needs Design Feedback Needs general design feedback. [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Feb 13, 2018
@youknowriad youknowriad mentioned this pull request Feb 14, 2018
Closed
@karmatosed
Copy link
Member

👍 from me, really like this.

@youknowriad youknowriad force-pushed the update/tweak-is-typing branch from bbe948d to c0f0b28 Compare February 15, 2018 11:35
@youknowriad youknowriad merged commit be3926b into master Feb 15, 2018
@youknowriad youknowriad deleted the update/tweak-is-typing branch February 15, 2018 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

@mtias mtias Awaiting requested review from mtias

Assignees

@youknowriad youknowriad

Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Design Feedback Needs general design feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youknowriad @aduth @karmatosed