Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n of created Navigation menu title #48773

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Mar 6, 2023

What?

Makes the post title of the Navigation menu translated.

Why?

Strings should be translatable.

How?

Uses _x() to ensure context is provided.

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@getdave getdave self-assigned this Mar 6, 2023
@getdave getdave added Internationalization (i18n) Issues or PRs related to internationalization efforts [Block] Navigation Affects the Navigation Block labels Mar 6, 2023
@getdave getdave marked this pull request as ready for review March 6, 2023 10:39
@getdave getdave requested a review from tellthemachines as a code owner March 6, 2023 10:39
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@getdave getdave merged commit 6af2dc0 into trunk Mar 6, 2023
@getdave getdave deleted the update/translate-navigation-title-on-creation branch March 6, 2023 11:53
@github-actions github-actions bot added this to the Gutenberg 15.4 milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants