Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stylelint to 15.1 #48143

Closed
wants to merge 1 commit into from
Closed

Update stylelint to 15.1 #48143

wants to merge 1 commit into from

Conversation

paulschreiber
Copy link

What?

Updated stylelint to 15.1. Fixes #48142.

Why?

Allows people to use the current version of stylelint alongside @wordpress/stylelint-config.

@paulschreiber
Update stylelint to 15.1
b669bf1 
Updated stylelint to 15.1. Fixes WordPress#48142.
@paulschreiber paulschreiber requested a review from ntwb as a code owner February 16, 2023 19:34
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 16, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @paulschreiber! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@gziolo gziolo added the [Tool] stylelint config /packages/stylelint-config label Feb 17, 2023
@gziolo gziolo added the [Type] Breaking Change For PRs that introduce a change that will break existing functionality label Mar 19, 2023
@gziolo
Copy link
Member

gziolo commented Mar 19, 2023 •
edited
Loading

Thank you for opening this PR. I see there is a newer PR #48769 trying to update the stylelint dependency. Do you know what’s the difference?

Edit: the alternative PR probably removes the deprecated rules listed in #48142 (comment).

@gziolo gziolo mentioned this pull request May 5, 2023
Closed
@gziolo
Copy link
Member

gziolo commented May 16, 2023

Thank you for opening this PR. There is more work necessary, as explored in #50336.

@noahtallen noahtallen mentioned this pull request Oct 9, 2023
Open
1 task
@mikeybinns mikeybinns mentioned this pull request Aug 27, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 27, 2024
@gziolo
Copy link
Member

gziolo commented Aug 29, 2024 •
edited
Loading

There is now another more up-to-date PR from @mikeybinns that is fully functional, ready for review and testing:

Thank you so much for your contribution!

@gziolo gziolo closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Status] In Progress Tracking issues with work in progress [Tool] stylelint config /packages/stylelint-config [Type] Breaking Change For PRs that introduce a change that will break existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@wordpress/stylelint-config uses outdated stylelint (14.2)
2 participants
@paulschreiber @gziolo