Fix type error when merging blocks #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
approved these changes
Feb 1, 2018
|
Since it was added, removed, and now re-added, could you leave a comment on my this is needed? Seems good practice regardless to leave comments on any use of |
When we merge two blocks by pressing the BACKSPACE KEY, the TinyMCE instance belonging to the second block is destroyed. This results in a type error raised by a TinyMCE event handler that is listening to the *same* event. By *immediately* preventing propagation, we can stop TinyMCE's handler from ever running.
noisysocks
force-pushed
the
fix/type-error-when-merging-blocks
branch
from
0fd7d66 to
493ea9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this is
Fixes #4580. This was a regression introduced by #4395.
When we merge two blocks by pressing the BACKSPACE KEY, the TinyMCE instance belonging to the second block is destroyed. This results in a type error raised by a TinyMCE event handler that is listening to the same event.
By immediately preventing propagation, we can stop TinyMCE's handler from ever running.
How to test
Check that the bug is fixed:
Check that we didn't break #4395: