BottomSheetSettings: remove unneeded settings prop #47332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
One more similar removal in the Cover block. Same story: |
|
Flaky tests detected in 694e470. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3976301820
|
geriux
added
Mobile App - i.e. Android or iOS
geriux
approved these changes
Jan 24, 2023
geriux
removed
the
Mobile App - Automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a
settingsprop (passed fromwithSelect) from theBottomSheetSettingscomponent. The prop stopped being used in #38417, which started usinguseMobileGlobalStylesColors, but wasn't removed.The prop was passed as a part of the
...propsspread to<BottomSheet>and<ImageLinkDestinationsScreen>, and I verified that these components don't use it.Found this when reviewing usages of the
getSettings()selector across Gutenberg.