Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation]: Update Extending the Query Loop block docs #44703

Merged
merged 3 commits into from
Oct 6, 2022
Merged

[Documentation]: Update Extending the Query Loop block docs #44703

merged 3 commits into from
Oct 6, 2022

Conversation

ntsekouras
Copy link
Contributor

Follow up of: #44137

@ntsekouras ntsekouras added the Needs User Documentation Needs new user documentation label Oct 5, 2022
@ntsekouras ntsekouras requested a review from mcsf October 5, 2022 10:59
@ntsekouras ntsekouras requested a review from ajitbohra as a code owner October 5, 2022 10:59
@ntsekouras ntsekouras self-assigned this Oct 5, 2022
sunyatasattva
sunyatasattva suggested changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@sunyatasattva sunyatasattva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job clarifying and extending certain parts! Thank you for doing that. Submitted a few suggestions, nothing major.

I noticed you really dislike colons! 😂

@ntsekouras @ryanwelcher @sunyatasattva
Apply suggestions from code review
12a9753 
Co-authored-by: Ryan Welcher <me@ryanwelcher.com>
Co-authored-by: Lucio Giannotta <sunyatasattva@gmail.com>
@ntsekouras ntsekouras requested a review from annezazu October 5, 2022 16:07
mcsf
mcsf approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clear; just have one thing to amend.

@ntsekouras @mcsf
Apply suggestions from code review
1690dd7 
Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
@ntsekouras ntsekouras merged commit c1d5686 into trunk Oct 6, 2022
@ntsekouras ntsekouras deleted the update/extend-query-loop-docs branch October 6, 2022 13:43
@github-actions github-actions bot added this to the Gutenberg 14.4 milestone Oct 6, 2022
@femkreations femkreations removed the Needs User Documentation Needs new user documentation label Jan 26, 2023
@bph bph added the [Type] Developer Documentation Documentation for developers label Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanwelcher ryanwelcher ryanwelcher left review comments

@mcsf mcsf mcsf approved these changes

@sunyatasattva sunyatasattva sunyatasattva approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@annezazu annezazu Awaiting requested review from annezazu

Assignees

@ntsekouras ntsekouras

Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 14.4
Development

Successfully merging this pull request may close these issues.
6 participants
@ntsekouras @mcsf @ryanwelcher @sunyatasattva @bph @femkreations