-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
theme.json
: add title
key to i18n schema
#39936
Conversation
themejson
: add title
key to i18n schematheme.json
: add title
key to i18n schema
Something I was wondering, we probably need to wrap the "title" property in gutenberg/lib/compat/wordpress-6.0/class-gutenberg-rest-global-styles-controller.php Lines 234 to 238 in 2a2938f
|
Yeah, we need to do other things for it to be picked up. I've already started looking into this, but I also want to fast-track the schema update and the corresponding WordPress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is 👌.
This is related to Gutenberg changes in WordPress/gutenberg#39936 that marks the "title" key as translatable field in "theme.json" files. See also #54336. Props oandregal. Built from https://develop.svn.wordpress.org/trunk@53038 git-svn-id: http://core.svn.wordpress.org/trunk@52627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This is related to Gutenberg changes in WordPress/gutenberg#39936 that marks the "title" key as translatable field in "theme.json" files. See also #54336. Props oandregal. Built from https://develop.svn.wordpress.org/trunk@53038 git-svn-id: https://core.svn.wordpress.org/trunk@52627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Follow-up to #39322 and #39715
Related WordPress
trunk
PR at WordPress/wordpress-develop#2483What?
This PR adds
title
as a new key to translate from atheme.json
file. It's necessary to fix the wp-cli i18n-command tests at wp-cli/i18n-command#306Why?
The
title
key from a style variation is shown to the user, hence, it needs to be translatable.How?
By adding the key to the i18n schema we allow the i18n-command from the wp-cli to pick it up. See wp-cli/i18n-command#306 Though the wp-cli uses the schema from WordPress
trunk
so we also need to port the changes there.Testing Instructions
This PR only prepares the code for the wp-cli to pick up translations, so there's nothing to test other than verifying that it doesn't break anything. This is what I did: