Fix - Block editor settings mobile endpoint - Add missing global styles has support check #39806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
the
Global Styles
oandregal
added
[Type] Bug
oandregal
approved these changes
Mar 28, 2022
oandregal
deleted the
fix/block-editor-settings-mobile-add-global-styles-check
branch
draganescu
pushed a commit
that referenced
this pull request
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a missing check for only passing the
experimentalStylesdata for themes that support global styles.Why?
After some recent changes #39030 while moving some files, this check was left behind, causing issues on the latest production builds of the mobile WordPress apps.
How?
Brings back the missing
WP_Theme_JSON_Resolver_Gutenberg::theme_has_support()check.Testing Instructions
Seedletwp-json/wp-block-editor/v1/settings?context=mobile__experimentalStylesdata in the response. It should only be returned for block-based themes.Screenshots or screencast
N/A