Comments Query Loop: Always inherit from core Discussion settings #39664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalczaplinski
added
[Block] Comments
|
Size Change: -588 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
michalczaplinski
requested review from
ajitbohra,
mkaz,
ryanwelcher and
juanmaguitar
as code owners
michalczaplinski
removed request for
mkaz,
juanmaguitar,
ajitbohra and
ryanwelcher
michalczaplinski
deleted the
fix/comment-query-loop-do-not-inherit-settings
branch
This was referenced Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove the
inheritoption of the and ALWAYS inherit the settings of the Comments Query Loop from the core Discussion settings. This implies also removing the following attributes from the Comments Query Loop block as well any code that depends on them:perPageorderdefaultPageinheritAdditionally, we remove any options related to those attributes in the Inspector Controls of the Comments Query Loop.
Fixing #39648
Why?
It was identified that whenever the discussion settings are NOT inherited from Discussion settings and the user is allowed to control them per block, there are multiple subtle issues caused by the two mechanisms (the core settings and the block settings) being out of sync.
How?
Removing the aforementioned attributes and any code that depends on them.
Screenshots or screencast
Before:
First screenshot is when "inherit" is
true, the second one is when it'sfalse.After: