Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Extract the WritingFlow component as a reusable Editor component #3569

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

youknowriad
Copy link
Contributor

Related to #2761 (comment)

This PR extracts WritingFlow component to the reusable components folder.

Testing instructions

  • Test that arrow navigation between blocks works

@youknowriad youknowriad self-assigned this Nov 20, 2017
@codecov
Copy link

codecov bot commented Nov 20, 2017

Codecov Report

Merging #3569 into master will increase coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3569      +/-   ##
==========================================
+ Coverage    35.1%   35.17%   +0.07%     
==========================================
  Files         265      265              
  Lines        6734     6723      -11     
  Branches     1220     1218       -2     
==========================================
+ Hits         2364     2365       +1     
+ Misses       3693     3683      -10     
+ Partials      677      675       -2
Impacted Files Coverage Δ
editor/components/writing-flow/index.js 1.47% <ø> (ø)
editor/modes/visual-editor/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc46f77...fb36087. Read the comment docs.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still able to move blocks, code looks good 👍

@youknowriad youknowriad merged commit 465a718 into master Nov 20, 2017
@youknowriad youknowriad deleted the extract/writing-flow-component branch November 20, 2017 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants