ToggleGroupControl: Allow custom aria-label #35423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +19 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
ciampo
added
[a11y] Labelling
[Feature] Component System
ciampo
reviewed
Oct 7, 2021
packages/components/src/toggle-group-control/toggle-group-control-button.tsx
Show resolved
Hide resolved
ntsekouras
reviewed
Oct 8, 2021
packages/components/src/toggle-group-control/toggle-group-control-button.tsx
Show resolved
Hide resolved
ciampo
approved these changes
Oct 8, 2021
mirka
force-pushed
the
fix/toggle-group-aria-label
branch
from
7d41113 to
2399d96
Compare
7 tasks
priethor
added
the
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35381
Description
Allows a consumer to set a custom
aria-labelon aToggleGroupControlOption.The previous implementation explicitly set the
aria-labelto the value of the visiblelabel, which I believe is redundant due to the label string always being present as a child node in the accessibility tree.How has this been tested?
I added a story in the Storybook with an example use case.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).