Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Extract a reusable PostLastRevision component #3290

Merged
merged 1 commit into from
Nov 2, 2017

Conversation

youknowriad
Copy link
Contributor

Related to #2761 (comment)

All these (the sidebar panels) must be refactored slightly to drop all the "layout" pieces and keep only the "forms". For example, the sidebar panels like PostTaxonomies, we should extract only the PostTaxonomyForms into a reusable component without the expandable panel behavior that is specific to our current UI. (This step could be done in a separate PR preceding the directory structure change)

This PR addresses the comment above for the PostLastRevision component.

Testing instructions

  • Test that the last revision link is working as expected

@youknowriad youknowriad self-assigned this Nov 1, 2017
@codecov
Copy link

codecov bot commented Nov 1, 2017

Codecov Report

Merging #3290 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3290      +/-   ##
==========================================
- Coverage   31.05%   30.98%   -0.07%     
==========================================
  Files         232      234       +2     
  Lines        6521     6535      +14     
  Branches     1163     1165       +2     
==========================================
  Hits         2025     2025              
- Misses       3770     3782      +12     
- Partials      726      728       +2
Impacted Files Coverage Δ
editor/sidebar/last-revision/index.js 0% <0%> (ø) ⬆️
editor/post-last-revision/index.js 0% <0%> (ø)
editor/post-last-revision/check.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22af16c...1d767fc. Read the comment docs.

@youknowriad youknowriad merged commit 550025d into master Nov 2, 2017
@youknowriad youknowriad deleted the update/reusable-last-revision branch November 2, 2017 13:55
@gziolo
Copy link
Member

gziolo commented Nov 2, 2017

Nice one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants