Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: remove outer content margins to better match front-end #29453

Closed
wants to merge 1 commit into from
Closed

Site Editor: remove outer content margins to better match front-end #29453

wants to merge 1 commit into from

Conversation

creativecoder
Copy link
Contributor

Description

This change demonstrate removing the outer content margins from the site editor, to better match how the content looks on the front-end of the site (addresses #29357)

How has this been tested?

  • Using TT1 Blocks theme and editing a template
  • Manually checking the margins in the site editor are removed
  • Manually checking that changes do not bleed into the post/page editor

Screenshots

Header Footer
Screen Shot 2021-03-01 at 15 51 17 Screen Shot 2021-03-01 at 15 50 49

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 1, 2021
@github-actions
Copy link

github-actions bot commented Mar 1, 2021

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @creativecoder! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@creativecoder creativecoder self-assigned this Mar 2, 2021
@creativecoder creativecoder marked this pull request as draft March 2, 2021 23:09
@talldan talldan added [Feature] Full Site Editing CSS Styling Related to editor and front end styles, CSS-specific issues. labels Apr 1, 2021
@creativecoder
Copy link
Contributor Author

The site editor no longer shows the extra margins--closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants