Update improve backward compatibility for deprecated settings #25738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
ellatrix and
youknowriad
as code owners
|
Size Change: +944 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
|
It seems once we do that folks, should have the possibility to upgrade to the new API useEditorFeature. So I think it's probably better to wait for 5.6 before landing this as |
jorgefilipecosta
force-pushed
the
update/improve-backcompatibility-for-deprecated-settings
branch
from
393ccf9 to
ff854cd
Compare
|
This PR is a must-have for 5.6 because without the PR on 5.6 on themes that don't explicitly set a color palette, or gradients, or font sizes the defaults will not appear. As now the defaults are passed by the global styles mechanism that will not be part of 5.6. |
oandregal
approved these changes
Oct 9, 2020
|
Fixes #25652 |
jorgefilipecosta
force-pushed
the
update/improve-backcompatibility-for-deprecated-settings
branch
from
ff854cd to
17f8811
Compare
jorgefilipecosta
deleted the
update/improve-backcompatibility-for-deprecated-settings
branch
youknowriad
pushed a commit
that referenced
this pull request
Oct 12, 2020
|
I hate to say it, but this actually broke backwards compatibility (at least in the way we were using it). In order to enable custom line height for all themes, we were filtering editor settings to add the |
ockham
pushed a commit
to Automattic/wp-calypso
that referenced
this pull request
Oct 27, 2020
In WordPress/gutenberg#25738, Gutenberg moved the lineHeight setting to a new place in the settings object. It also introduced a (sort of?) bug where even though it has a mechanism to use the deprecated location for the setting, it is never used because the default value is returned instead. This simply updates our existing filter to enable line height in the new location if the new location exists. I left the old setting in place as well, just in case we still need to support older gutenberg versions.
|
Hi @noahtallen I believe this is a bug we need to fix. However, it seems to me that the bug is not in the client's Essentially, we need to make this work for the following two use cases:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves backward compatibility for deprecated settings.
It now follows this model:
How has this been tested?
I verified the default settings appear on the playground.
I verified the normal post editor still used settings from theme.json