-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Widget Editor] Fixed sidebar inserter #25681
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8e70a07
Fixed sidebar inserter
adamziel 6bc4b57
Styles for the title
adamziel de030e8
Scrollable toolbar on mobile
adamziel f640d11
Add a comment and extract handleClick into a separate function
adamziel e43e5c3
Fix the page height issue
adamziel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
packages/edit-widgets/src/components/layout/popover-wrapper.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { | ||
| withConstrainedTabbing, | ||
| withFocusReturn, | ||
| withFocusOutside, | ||
| } from '@wordpress/components'; | ||
| import { Component } from '@wordpress/element'; | ||
| import { ESCAPE } from '@wordpress/keycodes'; | ||
|
|
||
| function stopPropagation( event ) { | ||
| event.stopPropagation(); | ||
| } | ||
|
|
||
| const DetectOutside = withFocusOutside( | ||
| class extends Component { | ||
| handleFocusOutside( event ) { | ||
| this.props.onFocusOutside( event ); | ||
| } | ||
|
|
||
| render() { | ||
| return this.props.children; | ||
| } | ||
| } | ||
| ); | ||
|
|
||
| const FocusManaged = withConstrainedTabbing( | ||
| withFocusReturn( ( { children } ) => children ) | ||
| ); | ||
|
|
||
| export default function PopoverWrapper( { onClose, children, className } ) { | ||
| // Event handlers | ||
| const maybeClose = ( event ) => { | ||
| // Close on escape | ||
| if ( event.keyCode === ESCAPE && onClose ) { | ||
| event.stopPropagation(); | ||
| onClose(); | ||
| } | ||
| }; | ||
|
|
||
| // Disable reason: this stops certain events from propagating outside of the component. | ||
| // - onMouseDown is disabled as this can cause interactions with other DOM elements | ||
| /* eslint-disable jsx-a11y/no-static-element-interactions */ | ||
| return ( | ||
| <div | ||
| className={ className } | ||
| onKeyDown={ maybeClose } | ||
| onMouseDown={ stopPropagation } | ||
| > | ||
| <DetectOutside onFocusOutside={ onClose }> | ||
| <FocusManaged>{ children }</FocusManaged> | ||
| </DetectOutside> | ||
| </div> | ||
| ); | ||
| /* eslint-enable jsx-a11y/no-static-element-interactions */ | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very generic component and I think ideally this becomes a set of hooks or a single hook as it's more about behavior and less about UI. (that said, it's separate from this PR)