Notices: Fix Array.reverse call
#2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to clone the input array to avoid mutating the original parameter
aduth
approved these changes
Aug 22, 2017
Codecov Report
@@ Coverage Diff @@
## master #2498 +/- ##
==========================================
+ Coverage 27.23% 27.41% +0.18%
==========================================
Files 161 161
Lines 4943 4957 +14
Branches 824 829 +5
==========================================
+ Hits 1346 1359 +13
Misses 3047 3047
- Partials 550 551 +1
Continue to review full report at Codecov.
|
mcsf
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to clone the input array to avoid mutating the original parameter.
cc #1437 (comment)