Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fixed table layout to table block #18870

Closed
wants to merge 3 commits into from
Closed

Adds fixed table layout to table block #18870

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69920ec
Adds fixed table layout to table block
Dec 2, 2019
4086e47
Removing the option
Dec 4, 2019
60b5f27
Changes from review
Dec 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/block-library/src/table/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
height: auto;

table {
table-layout: fixed;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this unnecessary since style.scss is loaded in the editor?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In testing it was for me, feel free to iterate on PR if you don't find it is in testing @ZebulanStanphill

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @ZebulanStanphill is right, it shouldn't be required.

// Ensure the table element is not full-width when aligned.
width: auto;
}
Expand Down
1 change: 1 addition & 0 deletions packages/block-library/src/table/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

table {
width: 100%;
table-layout: fixed;
}

// Fixed layout toggle
Expand Down