Parser: Fix default PHP parser to cast inner blocks as arrays #11678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the introduction of the default parsers we have had a bug in the PHP version whereby inner blocks were being popped onto the output stack as PHP classes instead of as simple associated arrays. Blocks that weren't inner blocks were being properly type-casted as arrays. This patch adds the cast in where it's needed in order to fix this inconsistent behavior. So far this hasn't caused any troubles or exposed itself but while working on other PRs like #11434 it became evident in test code.
dmsnell
added
the
[Feature] Parsing
gwwar
reviewed
Nov 10, 2018
| @@ -457,7 +457,7 @@ function add_freeform( $length = null ) { | |||
| */ | |||
| function add_inner_block( WP_Block_Parser_Block $block, $token_start, $token_length, $last_offset = null ) { | |||
| $parent = $this->stack[ count( $this->stack ) - 1 ]; | |||
| $parent->block->innerBlocks[] = $block; | |||
| $parent->block->innerBlocks[] = (array) $block; | |||
There was a problem hiding this comment.
For folks reviewing: http://php.net/manual/en/language.types.array.php#language.types.array.casting
pento
approved these changes
Nov 10, 2018
mtias
added
Internationalization (i18n)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the introduction of the default parsers we have had a bug in the
PHP version whereby inner blocks were being popped onto the output
stack as PHP classes instead of as simple associated arrays. Blocks
that weren't inner blocks were being properly type-casted as arrays.
This patch adds the cast in where it's needed in order to fix this
inconsistent behavior.
So far this hasn't caused any troubles or exposed itself but while
working on other PRs like #11434 it became evident in test code.
Testing
Hopefully you will see by inspection how limited this change is.
Nothing internally should be relying on the
WP_Block_Parser_Blockclasses so this change should simply be removing that leak.
Load up Gutenberg, try some things - I estimate that a smoke-test
should uncover problems.
Checklist: